SellPL
af8b28f6c6
ci.yml calls `scripts/ci.sh` rather than restating the checks: a workflow that reimplements them becomes a second definition of "done", and the two drift. Android runs as a separate job. It fails when the SDK is absent while ci.sh skips it — a developer should not be blocked by a missing toolchain, but a silently skipped Android build in CI means regressions ship unnoticed. Every action is pinned to an exact version. LICENSE.md records that no licence is chosen yet, and why it is not a formality: the choice is upstream of the UI toolkit decision, since Slint is GPL-3.0. Co-Authored-By: Claude Code <noreply@anthropic.com>
88 lines
2.7 KiB
Markdown
88 lines
2.7 KiB
Markdown
<!--
|
|
Pull request template for Blocker.
|
|
|
|
CLAUDE.md section 10.2 requires each PR to state: what changed, which section 1
|
|
requirement it covers, test evidence, and perf numbers if it touches the hot path.
|
|
|
|
Test evidence means pasted output. A claim that tests pass is not evidence; the
|
|
output is. Section 10.6: if a check fails, say so in the PR — do not weaken a test
|
|
to make it pass.
|
|
-->
|
|
|
|
## What changed
|
|
|
|
<!-- What this PR does, in a paragraph. Not a file list — the diff is the file list. -->
|
|
|
|
Refs #
|
|
|
|
## Which requirement this covers
|
|
|
|
<!--
|
|
Quote the relevant part of CLAUDE.md section 1. If this covers none, say so plainly
|
|
and explain why the change exists anyway — refactors and CI changes legitimately
|
|
cover no user-facing requirement, but that should be visible rather than assumed.
|
|
-->
|
|
|
|
Section 1:
|
|
|
|
## Test evidence
|
|
|
|
<!--
|
|
Paste the actual output of `scripts/ci.sh`. Not "all tests pass" — the output.
|
|
|
|
Note any check that SKIPPED, and why. A skip is not a pass, and saying so here is
|
|
part of the evidence.
|
|
```
|
|
|
|
$ scripts/ci.sh
|
|
...
|
|
```
|
|
|
|
## Performance
|
|
|
|
<!--
|
|
Required if this touches the hot path — the evaluator, the event loop, the block
|
|
screen, or anything that runs on every focus change (section 9).
|
|
|
|
Otherwise write "not affected" and say why.
|
|
-->
|
|
|
|
Measured against section 5:
|
|
|
|
| Metric | Target | Before | After |
|
|
|---|---|---|---|
|
|
| | | | |
|
|
|
|
Command used:
|
|
|
|
```
|
|
|
|
## Checklist
|
|
|
|
- [ ] Each commit builds and passes tests on its own (section 10.2)
|
|
- [ ] Commits are conventional (`feat:`, `fix:`, `perf:`, `refactor:`, `test:`, `docs:`, `ci:`)
|
|
- [ ] `scripts/ci.sh` passes, or every skip is explained above
|
|
- [ ] New golden decision-table cases are **added**, and behaviour changes are
|
|
matched by a case change in the same commit (the add-before-change rule)
|
|
- [ ] Every fallible OS or I/O call is handled — no `unwrap()`/`expect()` outside
|
|
tests (section 0 rule 5)
|
|
- [ ] Perf budget re-measured if the hot path was touched (section 9)
|
|
- [ ] Any platform that cannot comply has its gap documented in `docs/LIMITATIONS.md`
|
|
- [ ] No credentials, keystores, `.env` files, or local databases in the diff
|
|
- [ ] No secret, API token, SSH key, or private path appears in the diff
|
|
- [ ] No dependency added without sign-off (section 0 rule 3) and an ADR entry
|
|
|
|
## Notes for the reviewer
|
|
|
|
<!--
|
|
Anything you would flag yourself: a place you are unsure about, a shortcut taken, a
|
|
decision that needs a second opinion.
|
|
|
|
If a check fails, say so here. A failing check stated plainly is fine. A failing
|
|
check hidden by a weakened test is not, and section 10.6 prohibits it.
|
|
-->
|
|
|
|
## Do not merge this yourself
|
|
|
|
The agent does not merge its own PR (section 10.2). Squash or rebase merge, keep
|
|
history linear. Tag the milestone when it lands. |